Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for any motion and slo-no motion interrupts #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jasonhenderson
Copy link

I was trying to integrate the example for tracking motion provided by the arduino folks. It is a nice feature of this little IMU. Only had a couple of hours to do it, but the code was pretty straightforward. I tried to follow your convention as much as possible, and this led to adding a setPage method for swapping register pages. Don't know how much time I'll have to play around, but I was thinking about adding quat zeroing for mounting issues in another PR, perhaps in the /utility folder.

@@ -570,7 +858,8 @@ bool Adafruit_BNO055::write8(adafruit_bno055_reg_t reg, byte value)
Wire.send(value);
#endif
Wire.endTransmission();

delayMicroseconds(150);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add this delay?

Written by KTOWN for Adafruit Industries.
MIT license, all text above must be included in any redistribution
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why all these spacing changes? You should leave this as-is and focus on code changes that are germane to the PR...

@tve
Copy link

tve commented Jan 30, 2019

@microbuilder is there any chance to get some of the long pending PRs reviewed and merged for this library or have you guys abandoned it?

@ladyada
Copy link
Member

ladyada commented Jan 30, 2019

@tve hiya the best way you can help to get PR's merged is to test them - many PR's break builds or don't work, it takes time to validate them. if you test on ESP32/ESP8266/SAMD21/SAMD51/AVR we'll know that the PR did not make things worse :)

@mrplaygood
Copy link

Is this PR still in development? I would like to use the interrupt as well but my programming experience isn't that good to implement it on my own. So if this is still a thing I would be really glad!

@ruswerner
Copy link

@jasonhenderson Can you provide an example to setup an interrupt on anymotion event using your new code? I'm testing your code now and I think it would be good to create a new example in the examples folder to show the added functionality and how to use it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants